On Sat, Apr 16, 2011 at 12:25 AM, Nath, Arindam <Arindam.Nath@xxxxxxx> wrote: > Hi Andrei, > > I saw in one of the community threads that you also have a patch ready for supporting Auto CMD23 for SDHCI. Can you share the same with us? I would like to take a look at your patch first before deciding whether it would make sense for controllers which comply with Host Controller Spec v3.00. > Will send updated patch set in a few. You and Subhash are on the Cc. Once again, the Auto-CMD23 is completely untested. I would be extremely grateful if you can verify it. Is there any kind of error injection mechanism you guys use to verify the error paths for Auto 12/23? By the way - + /* If the host can perform ADMA operation, we reset SDMA flag */ + if (host->flags & SDHCI_USE_ADMA) + host->flags &= ~SDHCI_USE_SDMA; This seems completely unnecessary, as the code already prefers ADMA to SDMA. What do you think? A -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html