On Tue, Apr 12, 2011 at 11:57 AM, Chris Ball <cjb@xxxxxxxxxx> wrote: > Hi Andrei, > > On Mon, Apr 11 2011, Andrei Warkentin wrote: >> This fixes the out-of-spec erase/trim support. CMD38 argument >> is passed through an EXT_CSD byte instead of as the command >> argument. This has the effect that trims act as group erases, >> erasing more data than necessary. Secure trims/erases were also affected. >> >> N.B. This depends on the mmc_switch patch from the earlier boot partition >> patchset (MMC: Allow setting CMD timeout for CMD6 (SWITCH)). This also >> depends on the update core/quirks.c code. >> >> ToC: >> [PATCH 1/2] MMC: Support for block quirks. >> [PATCH 2/2] MMC: Fix erase/trim for certain SanDisk cards. > > Looks like these are missing your new timeout arg to mmc_switch(): > > drivers/mmc/card/block.c: In function ‘mmc_blk_issue_discard_rq’: > drivers/mmc/card/block.c:371:6: error: too few arguments to function ‘mmc_switch’ > include/linux/mmc/core.h:138:12: note: declared here > drivers/mmc/card/block.c: In function ‘mmc_blk_issue_secdiscard_rq’: > drivers/mmc/card/block.c:410:6: error: too few arguments to function ‘mmc_switch’ > include/linux/mmc/core.h:138:12: note: declared here > drivers/mmc/card/block.c:419:7: error: too few arguments to function ‘mmc_switch’ > > Thanks, > > - Chris. > -- > Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/> > One Laptop Per Child > I'm sorry about that. I was sure I had rebased it appropriately, but I had not. I will repush it. A -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
