On Mon, Apr 11, 2011 at 5:00 PM, Chris Ball <cjb@xxxxxxxxxx> wrote:
> Hi Andrei,
>
> On Mon, Apr 11 2011, Andrei Warkentin wrote:
>> Allows device MMC boot partitions to be accessed. MMC partitions
>> are treated effectively as separate block devices on the same
>> MMC card.
>>
>> Acked-by: Arnd Bergmann <arnd@xxxxxxxx>
>> Signed-off-by: Andrei Warkentin <andreiw@xxxxxxxxxxxx>
>
> Looks fine, but would you mind breaking out the {claim,release}_host
> changes around mmc_blk_issue_rq() into a separate patch? It doesn't
> look like they're obviously related to the partitioning support, but
> maybe I'm missing something.
>
So it was one of the two -
a) stick mmc_bkl_part_switch into mmc_blk_issue_secdiscard_rq,
mmc_blk_issue_discard_rq, and mmc_blk_issue_rw_rq.
b) Move claim/release into mmc_blk_issue_rq and put partition switch
code into one place.
(b) is cleaner. What do you think?
A
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
