Re: [PATCH 1/4] MMC: Rename erase_timeout to cmd_timeout.

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 11, 2011 at 2:18 PM, John Calixto
<john.calixto@xxxxxxxxxxxxxx> wrote:
> Hi Andrei,
>
> On Tue, 5 Apr 2011, Andrei Warkentin wrote:
>> diff --git a/include/linux/mmc/core.h b/include/linux/mmc/core.h
>> index 07f27af..a7d7da7 100644
>> --- a/include/linux/mmc/core.h
>> +++ b/include/linux/mmc/core.h
>> @@ -92,7 +92,7 @@ struct mmc_command {
>>   *              actively failing requests
>>   */
>>
>> -     unsigned int            erase_timeout;  /* in milliseconds */
>> +     unsigned int            cmd_timeout;    /* in milliseconds */
>>
>>       struct mmc_data         *data;          /* data segment associated with cmd */
>>       struct mmc_request      *mrq;           /* associated request */
>
> Could you rename this field to "cmd_timeout_ms"?  When I was testing the
> addition of cmd_timeout to my ioctl patch, I noticed that data timeout
> was being specified in ns and I had to scale cmd_timeout appropriately.
>

Yes! Absolutely. Just sent the updated patch set.

A
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux