Re: [PATCH v2] mmc: sdhci: add error checking for mmc_add_host

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Apr 04, 2011 at 03:07:02PM +0900, Jaehoon Chung wrote:
> Sometimes we can't add the device,but we didn't check any error status.
> Need to check error status for mmc_add_host.
> 
> Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> Signed-off-by: kyungmin Park <kyungmin.park@xxxxxxxxxxx>
> ---

Please add here what changed since the last revision.

You are still leaking the led_classdev. Why do you free the mmc_host when
registering it failed? Looking at the remove function as comparison, there are
still some buffers, timers, etc, forgotten :( Could you fix that, too, please?

Regards,

   Wolfram

-- 
Pengutronix e.K.                           | Wolfram Sang                |
Industrial Linux Solutions                 | http://www.pengutronix.de/  |

Attachment: signature.asc
Description: Digital signature


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux