OK. Anything else? Russ W. Knize Mobile Devices Android Platform Desk: 847-523-9381 Mobile: 224-622-1391 On Fri, Apr 1, 2011 at 7:28 PM, Andrei Warkentin <andreiw@xxxxxxxxxxxx> wrote: > Hi Russ, > > On Fri, Apr 1, 2011 at 10:58 AM, Russ Knize <Russ.Knize@xxxxxxxxxxxx> wrote: >> + /* >> + * Ignore switch errors from buggy cards that actually >> + * do switch successfully. >> + */ >> + err = mmc_set_power_class(host, max_dtr, bus_width); >> + if (err && err != -EBADMSG) >> + goto free_card; >> + > > 1) host->card is not yet set at this moment, you probably want to pass > card to mmc_set_power_class as well . > 2) It seems like you will call mmc_set_power_class even if bus_width > == MMC_BUS_WIDTH_1. Is that supposed to work? 7.6.3 seems to imply > power classes only apply to 4-bit and 8-bit bus widths. As does the > paragraph on top of Page 138 of eMMC 4.41 spec, which says that for > 1-bit bus configuration the default applies (class 0). > 3) Since the current code supports DDR modes, you probably want to > extend support for PWR_CL_DDR_52_(360|195) as well. > > Just curious, for the cards reporting switch errors but nonetheless > switching to the power class, do they update the EXT_CSD field? > > A > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
