Will Newton wrote: > On Wed, Mar 30, 2011 at 6:55 AM, Jaehoon Chung <jh80.chung@xxxxxxxxxxx> wrote: >> This patch is set the send_auto_stop bit in CMD register. >> If use DW_MCI_QUIRK_SEND_AUTO_STOP, helps to send an exact >> number of data bytes. >> >> >> Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx> >> Signed-off-by: Kyungmin Park <kyungmin.park@xxxxxxxxxxx> > > This is something I have been meaning to look into, does it improve > latency or throughput in your experiments? Not improve latency...but in my experiments, when i used this, i could find the stable throughput.. > > Is there a reason you have implemented it as a quirk? I would have > thought if it was a win (in performance or code size) it would be > applicable to all instances of this block? I didn't test every case..so Somebody doesn't want to use send_auto_stop, So i think good that used the quirks... you can see Send_Auto_Stop generation table in DesigneWare MMC controller spec I think that our case can use send_auto_stop...but i didn't ensure in other case > > If we implemented it as an unconditional feature then we could > probably remove some of the explicit stop handling code. > -- > To unsubscribe from this list: send the line "unsubscribe linux-mmc" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
