On Wednesday 30 March 2011, Andrei Warkentin wrote: > On Tue, Mar 22, 2011 at 4:11 PM, Andrei Warkentin <andreiw@xxxxxxxxxxxx> wrote: > > Allows device MMC boot partitions to be accessed. MMC partitions > > are treated effectively as separate block devices on the same > > MMC card. > > > > Anyone has any opinions on these changes as being good or bad? > Anything I should do differently? Or does everyone like this? I have no objections to the code, but I don't completely understand what it does. Maybe you can elaborate more in the patch description. A few questions from me that I suppose should be answered by the description: * Is each of the MMC partitions in turn a partitionable device like the user partition with its mmcblk0p1/p2/p3... devices? * Will this patch impact device naming? Suppose you have an existing machine with mmcblk0 and mmcblk1 on two physical eMMC devices. When you show the partitions as new block devices, could it happen that the names are now different as you get additional devices inbetween? That would need to be documented carefully, as it could break existing setups. * What devices specifically have these new partitions? Only eMMC 4.4 or also other versions? * Would the same method work to support the secure partition on SD cards? * How does a user identify which hardware partition corresponds to a given block device and vice versa? Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html