Hi Wolfram: Got that. Thanks for your reminder. Would follow your advice in future. Best Regards Richard Zhu > -----Original Message----- > From: Wolfram Sang [mailto:w.sang@xxxxxxxxxxxxxx] > Sent: Friday, March 25, 2011 4:53 PM > To: Zhu Richard-R65037 > Cc: linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; kernel@xxxxxxxxxxxxxx; linux- > mmc@xxxxxxxxxxxxxxx; cjb@xxxxxxxxxx; avorontsov@xxxxxxxxxxxxx; > eric@xxxxxxxxxx; linuxzsc@xxxxxxxxx; eric.miao@xxxxxxxxxx > Subject: Re: [PATCH V8 3/4] mmc: sdhci-esdhc: make the writel/readl as > the general APIs > > On Fri, Mar 25, 2011 at 11:39:05AM +0800, Richard Zhu wrote: > > Add one flag to indicate the GPIO CD/WP is enabled or not on imx > > platforms, and reuse the writel/readl as the general APIs for imx > > SOCs. > > > > Signed-off-by: Richard Zhu <Hong-Xing.Zhu@xxxxxxxxxxxxx> > > --- > > Please provide something like "changes since last time" _below_ this > dashed line "---" next time. Or use --cover-letter to introduce the > changes. > > Other than that > > Reviewed-by: Wolfram Sang <w.sang@xxxxxxxxxxxxxx> > > Regards, > > Wolfram > > -- > Pengutronix e.K. | Wolfram Sang > | > Industrial Linux Solutions | http://www.pengutronix.de/ > | -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html