On Thu, Mar 24 2011, Subhash Jadavani wrote: > Here "DMA engine" means we are using SPS BAM as DMA HW. > No, we are not using the "drivers/dma/dmaengine.c" because MSM SPS > driver is not exporting the dma compliant APIs to client. We are using > the MSM SPS driver's exported APIs directly from our driver. Not sure > what extra description we can put it in commit text. Any suggestion? I think the commit text should explain why this driver doesn't just use the DMA engine API. People are going to want to know that later on as well. I know you did an analysis for this driver, and it would be good to include that information in the commit text. Email me privately if you want some help with that. Currently none of the MSM DMA hardware uses the DMA engine API, and I think we need to figure out if we want to move to that at some point. I realize that the hardware (especially SPS BAM) does a lot more than regular DMA, this may involve extending DMA engine, which may or may not be appropriate. Thanks, David -- Sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
