Re: [PATCH 2/6] sh: ecovec: use the CONFIG_MMC_TMIO symbols instead of MFD

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, 13 Mar 2011, Magnus Damm wrote:

> On Fri, Mar 11, 2011 at 4:52 PM, Guennadi Liakhovetski
> <g.liakhovetski@xxxxxx> wrote:
> > The CONFIG_MFD_SH_MOBILE_SDHI Kconfig symbol is going to disappear soon,
> > switch ecovec to using CONFIG_MMC_TMIO(_MODULE).
> >
> > Signed-off-by: Guennadi Liakhovetski <g.liakhovetski@xxxxxx>
> > ---
> >  arch/sh/boards/mach-ecovec24/setup.c |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/arch/sh/boards/mach-ecovec24/setup.c b/arch/sh/boards/mach-ecovec24/setup.c
> > index 52751f0..37ad5dc 100644
> > --- a/arch/sh/boards/mach-ecovec24/setup.c
> > +++ b/arch/sh/boards/mach-ecovec24/setup.c
> > @@ -462,7 +462,7 @@ static struct i2c_board_info ts_i2c_clients = {
> >        .irq            = IRQ0,
> >  };
> >
> > -#ifdef CONFIG_MFD_SH_MOBILE_SDHI
> > +#if defined(CONFIG_MMC_TMIO) || defined(CONFIG_MMC_TMIO_MODULE)
> >  /* SDHI0 */
> 
> What's wrong with CONFIG_MMC_SDHI? Too early in the patch series?
> 
> I can't really see what the ecovec board has in common with the tmio
> mmc implementation. Or did you mean the CONFIG_MMC_TMIO_CORE?

Right, sure, it must be CONFIG_MMC_TMIO_CORE. CONFIG_MFD_SH_MOBILE_SDHI 
has to go, because it is removed in a future patch. Will resubmit, thanks!

Regards
Guennadi

> 
> Perhaps this is just a stop-gap solution and it is being fixed in V2 patch 7/7 ?
> 
> Thanks,
> 
> / magnus
> 

---
Guennadi Liakhovetski, Ph.D.
Freelance Open-Source Software Developer
http://www.open-technology.de/
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux