On Monday 07 March 2011, Andrei Warkentin wrote: > > I took a look at quirks.c in linux-next. It's a bit sdio-specific... I > would extend mmc_fixup to contain card type (to know if cis > vendor/device should be checked) as well as name/manfid/oemid and rev > id (which is just a combination of hwrev, fwrev and date). Makes sense. > Vendor_fixup would be the top-level card fixup. > I would add blk_fixup (so block specific information like desired > write align size can be kept inside mmc_blk_data instead of polluting > mmc_card). > > ...and to support part reliability workarounds for Toshiba cards, will > add a blk_adjust method to be invoked inside blk req handling. > > Arnd, what do you think? I'm still not comfortable with having the blk_adjust method. I think it would be much better to encode that behavior in an abstract way in the block driver and set a flag to enable it in the quirks file. Arnd -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
