> I took a look at quirks.c in linux-next. It's a bit sdio-specific... I > would extend mmc_fixup to contain card type (to know if cis > vendor/device should be checked) as well as name/manfid/oemid and rev > id (which is just a combination of hwrev, fwrev and date). Feel free to change mmc_fixup. The quirk.c is made to be extended. > > Vendor_fixup would be the top-level card fixup. > I would add blk_fixup (so block specific information like desired > write align size can be kept inside mmc_blk_data instead of polluting > mmc_card). > > ...and to support part reliability workarounds for Toshiba cards, will > add a blk_adjust method to be invoked inside blk req handling. > > Arnd, what do you think? > > Pierre, what do you think about my above ideas of extending the > current quirks.c? Please see the following patches, which were my > original submissions... I think your work sounds promising. Look at pci/quirk.c it's 3k loc, with very various things. IMHO, we should just list cards, and set quirk flags, and quirk parameters in quirk.c. And put nice generic card independent quirk code in block.c. How is it possible to say generically: "avoid writes < 12K that are 8K unaligned and cross an 8K barrier"? Pierre --------------------------------------------------------------------- Intel Corporation SAS (French simplified joint stock company) Registered headquarters: "Les Montalets"- 2, rue de Paris, 92196 Meudon Cedex, France Registration Number: 302 456 199 R.C.S. NANTERRE Capital: 4,572,000 Euros This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies. -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
