Hi,
On Thu, Feb 17, 2011 at 01:09:04PM +0900, Jaehoon Chung wrote:
> Hi..
>
> > Why skip (1 << 1)? (There's also BIT(0) -> BIT(2) if you prefer.)
>
> My mistake..sorry..and thanks for your comment..
> I resend the patch applied BIT(0)-BIT(2)
No problem. Will, may I re-use your ACK for this patch?
>
> Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> ---
> include/linux/mmc/dw_mmc.h | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
> index 16b0261..3f22c20 100644
> --- a/include/linux/mmc/dw_mmc.h
> +++ b/include/linux/mmc/dw_mmc.h
> @@ -165,14 +165,12 @@ struct dw_mci_dma_ops {
> };
>
> /* IP Quirks/flags. */
> -/* No special quirks or flags to cater for */
> -#define DW_MCI_QUIRK_NONE 0
> /* DTO fix for command transmission with IDMAC configured */
> -#define DW_MCI_QUIRK_IDMAC_DTO 1
> +#define DW_MCI_QUIRK_IDMAC_DTO BIT(0)
> /* delay needed between retries on some 2.11a implementations */
> -#define DW_MCI_QUIRK_RETRY_DELAY 2
> +#define DW_MCI_QUIRK_RETRY_DELAY BIT(1)
> /* High Speed Capable - Supports HS cards (upto 50MHz) */
> -#define DW_MCI_QUIRK_HIGHSPEED 4
> +#define DW_MCI_QUIRK_HIGHSPEED BIT(2)
>
>
> struct dma_pdata;
--
Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
