Hi,
On Wed, Feb 16, 2011 at 03:19:28PM +0900, Jaehoon Chung wrote:
> If we need some quirks, maybe add quirks in future
> But now, quirks value set to integer..later we should be confused..
> So i think that need bit-shift control.
>
> And If we need not any quirks, we didn't set anything..
> (Need not DW_MCI_QUIRK_NONE)
>
> Signed-off-by: Jaehoon Chung <jh80.chung@xxxxxxxxxxx>
> ---
> include/linux/mmc/dw_mmc.h | 8 +++-----
> 1 files changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/include/linux/mmc/dw_mmc.h b/include/linux/mmc/dw_mmc.h
> index 16b0261..8614832 100644
> --- a/include/linux/mmc/dw_mmc.h
> +++ b/include/linux/mmc/dw_mmc.h
> @@ -165,14 +165,12 @@ struct dw_mci_dma_ops {
> };
>
> /* IP Quirks/flags. */
> -/* No special quirks or flags to cater for */
> -#define DW_MCI_QUIRK_NONE 0
> /* DTO fix for command transmission with IDMAC configured */
> -#define DW_MCI_QUIRK_IDMAC_DTO 1
> +#define DW_MCI_QUIRK_IDMAC_DTO (1 << 0)
> /* delay needed between retries on some 2.11a implementations */
> -#define DW_MCI_QUIRK_RETRY_DELAY 2
> +#define DW_MCI_QUIRK_RETRY_DELAY (1 << 2)
> /* High Speed Capable - Supports HS cards (upto 50MHz) */
> -#define DW_MCI_QUIRK_HIGHSPEED 4
> +#define DW_MCI_QUIRK_HIGHSPEED (1 << 3)
>
Why skip (1 << 1)? (There's also BIT(0) -> BIT(2) if you prefer.)
Thanks,
--
Chris Ball <cjb@xxxxxxxxxx> <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
