Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 25 Jan 2011, Tony Olech wrote:

> On Tue, 2011-01-25 at 10:13 +0100, Wolfram Sang wrote:
> > > The intended use of the read-only sysfs file is to enable first-line
> > > support staff to determine quickly what actual firmware file is being
> > > used.
> > You have that in the driver (and similar ones):
> > +	dev_info(&vub300->udev->dev, "requesting offload firmware %s\n",
> > +		 vub300->vub_name);
> > Won't checking the logs do?
> >    Wolfram
> 
> Nearly, but there is one crucial difference, the logs
> are historic and the sysfs is current.

I personally have no problem with your exporting the firmware name 
through sysfs for human consumption only and that no user space tools 
rely on this.


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux