Re: [PATCH] mmc: USB SDIO/SD/MMC Host Controller (VUB300) driver Resubmission

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, 21 Jan 2011, Tony Olech wrote:

> Add a driver for Elan Digital System's VUB300 chip
> which is a USB connected SDIO/SDmem/MMC host controller.
> A VUB300 chip enables a USB 2.0 or USB 1.1 connected host
> computer to use SDIO/SD/MMC cards without the need for
> a directly connected, for example via PCI, SDIO host
> controller.
> 
> Signed-off-by: Anthony F Olech <tony.olech@xxxxxxxxxxxxxxxxxxxxxx>
> ---
> This is the second submission attempt.
> There are 5 "do not initialise statics" errors reported by scripts/checkpatch.pl

you probably should fix those.  They are due to lines such as:

static int pad_input_to_usb_pkt = 0;
static int disable_offload_processing = 0;
static int force_1_bit_data_xfers = 0;
static int force_polling_for_irqs = 0;

Since those are global variables, you may omit to initialize them to 0 
which would then allocate them to the .bss section which is not included 
in the compiled binary, and automatically cleared to zero at run time.


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux