On Mon, Jan 24, 2011 at 9:17 PM, Bing Zhao <bzhao@xxxxxxxxxxx> wrote: > Hi Ohad, > >> -----Original Message----- >> From: Ohad Ben-Cohen [mailto:ohad@xxxxxxxxxx] >> Sent: Saturday, January 22, 2011 2:01 PM >> To: zhangfei gao >> Cc: Nicolas Pitre; Bing Zhao; Sahitya Tummala; linux-mmc@xxxxxxxxxxxxxxx; Michal Miroslaw; Chris Ball; >> Andrew Morton; Maxim Levitsky >> Subject: Re: [PATCH v2] sdio: skip initialization on powered resume >> >> On Fri, Jan 21, 2011 at 11:07 AM, zhangfei gao <zhangfei.gao@xxxxxxxxx> wrote: >> > Do you have any updated patch to skip mmc_sdio_init_card in resume back. >> > We need such patch in enable host sleep feature for mrvl8787. >> >> Is mrvl8787 a removable card ? > > It can be either a removable or non-removable card, depending on what platform is used. > >> >> I'm asking because we already skip mmc_sdio_init_card() for >> powered-resumed nonremovable cards (check out commit 3cfc33a "mmc: >> sdio: don't reinitialize nonremovable powered-resumed cards"). > > Thanks for the info. > >> >> I'm not familiar with marvell's cards, but I do remember a thread >> mentioning they have dedicated reset GPIOs, and that may suggest they >> are nonremovables. If that's the case, simply setting >> MMC_CAP_NONREMOVABLE on the relevant slot should do the trick for you. > > I think this approach works for Zhangfei on his embedded platform on which the 8787 card is non-removable. Hi, Ohad, Thanks for your patch, it is workable on the platform where mrvl8787 is non-removable. However, we still have platform mrvl8787 is removable, SDHCI_PRESENT_STATE can be read out value. Could we remove mmc_card_is_removable(host) condition, the skip is not related with whether card is removable or not, do you think so? Thanks a lot. > > Regards, > > Bing > -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
