RE: [PATCH v2] sdio: skip initialization on powered resume

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, 2 Sep 2010, Bing Zhao wrote:

> > Please look at the if() condition, and at the last argument to
> > mmc_sdio_init_card(), then ponder.
> 
> You are right. The last argument passed to mmc_sdio_init_card() is zero actually.
> 
> 		err = mmc_sdio_init_card(host, host->ocr, host->card, 0);
> 
> > 
> > I think the proper fix goes _inside_ mmc_sdio_init_card() as there are
> > certainly still validation checks which are appropriate to perform.
> 
> When you have a thought for the fix, I can do the testing on my system.

I'm telling you that you should use the powered_resume argument of 
mmc_sdio_init_card() to skip problematic initializations inside 
mmc_sdio_init_card() when powered_resume is not zero.  Looking at the 
existing code should give you examples of how powered_resume is used and 
why.


Nicolas
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux