Hi Olof, happy new 2011, first of all. On Thu, Dec 23, 2010 at 10:26:16AM -0800, Olof Johansson wrote: > > I tend to NACK it (but I am not the maintainer). I'd prefer to see a > > draft of your idea of a sdhci_add_host_fixup()-function :) > > See, I tend to get annoyed when I get asked to clean up others' messes > because something I do is all of the sudden held to a higher standard > than they have been. If I wasn't stubborn, the bits would have run out in October already, and you'd be in a worse situation now ;) That put aside, I anticipated that Chris is going to pick up your patches nonetheless (which causes no hard feelings here), that's why I wrote "I am not the maintainer". BTW I'd say cleaning up mess from the past is not that uncommon in kernel-development (think BKL), and raising standards is a good thing as well, no? I see your point, though, that if you introduce a fixup()-function now, nobody will convert an existing driver to it. It would be nice to have the cleanup in one go, but until someone is driving/funding this bigger step, we have to fiddle with incremental improvements which need a bit more negotiation, it seems. Kind regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
