On Thu, Dec 23, 2010 at 3:26 AM, Wolfram Sang <w.sang@xxxxxxxxxxxxxx> wrote: > On Thu, Dec 23, 2010 at 03:27:54AM -0600, Olof Johansson wrote: >> Some controllers misparse segment length 0 as being 0, not 65536. Add >> a quirk to deal with it. >> >> Signed-off-by: Olof Johansson <olof@xxxxxxxxx> > > I tend to NACK it (but I am not the maintainer). I'd prefer to see a > draft of your idea of a sdhci_add_host_fixup()-function :) See, I tend to get annoyed when I get asked to clean up others' messes because something I do is all of the sudden held to a higher standard than they have been. So, I see one of three options: * This go in, and I clean up some of the other drivers separately, _as promised_ * I do a sdhci_host_fixup() function, and only clean up my driver and the rest will be cleaned up... never, probably * I just remove this quirk, repost my driver without it, carry the quirk out of tree and get on with other things that I actually care about So, don't overdo it. I already promised I would help clean up this subsystem. Ok? Thanks, -Olof -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
