> I'll whip up the changes and see how invasive it gets as a -pltfm > driver. It shouldn't be too bad. I'll repost the series that way, but > I will still keep the quirks for now and do a pass reworking these as > well as others separately (see below). Sounds great! > Anyway, I wonder if it does makes some sense to add a sdhci_ops callback > for fixing up the mmc settings after setting the defaults in host_add, > and for not just -pltfm. A handful of quirks are already only used for > overriding defaults, and they could be freed up. There's a few more that > are only used by a single driver and are suitable for handling through > overloaded register read/write functions. Yes, exactly. I'd think more than 50% of the quirks can go away. > I'll do a first pass, but it might take me a week or two due to other > more pressing things. I perfectly understand. Thanks for looking into it. Kind regards, Wolfram -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
