On Tue, 2010-12-07 at 16:25 +0530, Sahitya Tummala wrote:
> Enable prog done interrupt for stop command(CMD12) that is sent
> after a multi-block write(CMD25). The PROG_DONE bit is set when
> the card has finished its programming and is ready for next data.
What's the benefit ? It looks like there is one, but please describe it.
> if (status & (MCI_CMDSENT | MCI_CMDRESPEND | MCI_CMDCRCFAIL |
> - MCI_CMDTIMEOUT) && host->curr.cmd) {
> + MCI_CMDTIMEOUT | MCI_PROGDONE) && host->curr.cmd) {
Add a line break here instead of weird spacing.
> msmsdcc_do_cmdirq(host, status);
> }
>
> diff --git a/drivers/mmc/host/msm_sdcc.h b/drivers/mmc/host/msm_sdcc.h
> index 996990d..ac79ed9 100644
> --- a/drivers/mmc/host/msm_sdcc.h
> +++ b/drivers/mmc/host/msm_sdcc.h
> @@ -138,7 +138,7 @@
> #define MCI_IRQENABLE \
> (MCI_CMDCRCFAILMASK|MCI_DATACRCFAILMASK|MCI_CMDTIMEOUTMASK| \
> MCI_DATATIMEOUTMASK|MCI_TXUNDERRUNMASK|MCI_RXOVERRUNMASK| \
> - MCI_CMDRESPENDMASK|MCI_CMDSENTMASK|MCI_DATAENDMASK)
> + MCI_CMDRESPENDMASK|MCI_CMDSENTMASK|MCI_DATAENDMASK|MCI_PROGDONEMASK)
>
> /*
> * The size of the FIFO in bytes.
> @@ -245,6 +245,8 @@ struct msmsdcc_host {
> struct mmc_command *cmd_cmd;
> u32 cmd_c;
>
> + unsigned int prog_scan;
> + unsigned int prog_enable;
These need to be bool, and you need to use true and false instead of 1
and 0.
Daniel
--
Sent by a consultant of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum.
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
