Re: [patch] sdhci: remove SDHCI_QUIRK_FORCE_1_BIT_DATA

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Tue, Nov 09, 2010 at 06:37:58AM -0500, zhangfei gao wrote:
> Here is patch to remove SDHCI_QUIRK_FORCE_1_BIT_DATA, which only used
> in drivers/mmc/host/sdhci-of-core.c.
> The reason is quirk is too valuable resource, the type is u32, while
> the highest is (1<<29) now.

FYI, initially that wasn't a quirk. Here is Pierre's last opinion on that:

http://lists.ozlabs.org/pipermail/devicetree-discuss/2009-June/000981.html

Thanks,

> 1. MMC_CAP_4_BIT_DATA | MMC_CAP_8_BIT_DATA  is opened by default in sdhci.c
> 2. platform driver could close such flag after sdhci_add_host.
> 
> We have verified on our platform, would you mind check whether it
> impact your driver behavior.

-- 
Anton Vorontsov
email: cbouatmailru@xxxxxxxxx
irc://irc.freenode.net/bd2
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux