On Mon, Oct 11, 2010 at 11:00:30PM -0400, Nicolas Pitre wrote: > On Tue, 12 Oct 2010, Chris Ball wrote: > > > Hi, > > > > On Mon, Oct 11, 2010 at 09:50:46PM -0400, Nicolas Pitre wrote: > > > On Mon, 11 Oct 2010, Eric Bénard wrote: > > > > since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan > > > > includes a pr_info which prints 4 lines each second for hosts configured > > > > with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc. > > > > This patch increase log level to debug (but maybe the right solution > > > > would be to remove this log). > > > > > > Indeed. Flooding the log with debug messages is not much better. > > > > Other options include: > > > > (a) Turn the message into a DBG(). (CONFIG_MMC_DEBUG=y) > > (b) Turn the message into a DBG(), predicated on !MMC_CAP_NEEDS_POLL. > > (c) Remove the message. > > > > Any thoughts? I'll go with (c) unless we agree on a better idea. > > My preference would be (a). You don't lose the intended debugging aid > but it has to be turned on explicitly. The people who might care > most probably have CONFIG_MMC_DEBUG=y already. +1 There has been a lot of discussion/issues about the initialization frequency, so this output might be desired in special situations. -- Pengutronix e.K. | Wolfram Sang | Industrial Linux Solutions | http://www.pengutronix.de/ |
Attachment:
signature.asc
Description: Digital signature
