Re: [PATCH] mmc_rescan: reduce verbosity

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi,

On Mon, Oct 11, 2010 at 09:50:46PM -0400, Nicolas Pitre wrote:
> On Mon, 11 Oct 2010, Eric Bénard wrote:
> > since commit 820f2bcfdc32cd90061224c930cf670f961e12d1 mmc_rescan
> > includes a pr_info which prints 4 lines each second for hosts configured
> > with MMC_CAP_NEEDS_POLL. Tested on i.MX51's sdhci-esdhc.
> > This patch increase log level to debug (but maybe the right solution
> > would be to remove this log).
> 
> Indeed.  Flooding the log with debug messages is not much better.

Other options include:

(a) Turn the message into a DBG().  (CONFIG_MMC_DEBUG=y)
(b) Turn the message into a DBG(), predicated on !MMC_CAP_NEEDS_POLL.
(c) Remove the message.

Any thoughts?  I'll go with (c) unless we agree on a better idea.

Thanks,

-- 
Chris Ball   <cjb@xxxxxxxxxx>   <http://printf.net/>
One Laptop Per Child
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html


[Index of Archives]     [Linux USB Devel]     [Linux Media]     [Video for Linux]     [Linux Audio Users]     [Yosemite News]     [Linux Kernel]     [Linux SCSI]

  Powered by Linux