On Thu, Aug 26, 2010 at 03:16:40PM -0700, Andrew Morton wrote:
> On Thu, 26 Aug 2010 23:10:24 +0100
> Matt Fleming <matt@xxxxxxxxxxxxxxxxx> wrote:
>
> > I've stuck my oar in and confused everybody now, it seems.
>
> I've just unconfused myself my dropping the patch ;) Please send new
> one(s) when the dust has settled?
Sure thing.
> The only tmio_mmc patch in my tree at present is
> tmio_mmc-dont-clear-unhandled-pending-interrupts:
>
>
>
>
> From: Yusuke Goda <yusuke.goda.sx@xxxxxxxxxxx>
>
> Previously, it was possible for ack_mmc_irqs() to clear pending interrupt
> bits in the CTL_STATUS register, even though the interrupt handler had not
> been called. This was because of a race that existed when doing a
> read-modify-write sequence on CTL_STATUS. After the read step in this
> sequence, if an interrupt occurred (causing one of the bits in CTL_STATUS
> to be set) the write step would inadvertently clear it.
>
> This patch eliminates this race by only writing to CTL_STATUS and clearing
> the interrupts that were passed as an argument to ack_mmc_irqs()."
>
Would you mind adding this snippet to the end of the changelog?
"Observed with the TMIO_STAT_RXRDY bit together with CMD53
on AR6002 and BCM4318 SDIO cards in polled mode."
And these tags,
Acked-by: Magnus Damm <damm@xxxxxxxxxxxxx>"
Tested-by: Arnd Hannemann <arnd@xxxxxxxxxx>"
Acked-by: Ian Molton <ian@xxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-mmc" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
