Thanks for your review! On Fri, May 28, 2010 at 02:40:27PM -0700, Andrew Morton wrote: > On Tue, 25 May 2010 18:10:28 +0200 (CEST) > Micha__ Miros__aw <mirq-linux@xxxxxxxxxxxx> wrote: > > This is needed to avoid code duplication in SD-combo support. > hm. Perhaps you could have told us a bit more about it than this. > > +int mmc_sd_get_cid(struct mmc_host *host, u32 ocr, u32 *cid) > > +int mmc_sd_get_csd(struct mmc_host *host, struct mmc_card *card) > > +int mmc_sd_setup_card(struct mmc_host *host, struct mmc_card *card, > > +unsigned mmc_sd_get_max_clock(struct mmc_card *card) > > +void mmc_sd_go_highspeed(struct mmc_card *card) > These are global symbols, but they are not exported to (other) modules. > That's odd. I'd have expected to see them either `static' or > EXPORT_MODULE()d. This is all contained in mmc_core.ko and needs not be exported to other modules. A SD-combo card is a SD (memory) and SDIO in one package - the only changes needed are in initialization sequence, after which both parts are mostly independent. > I'll take the lack of a signed-off-by: and the "RFC" as signal to not > apply these patches. I would like for this to get tested by other people first, but it looks like not many kernel developers use SD combo cards. I'll resend the patches after applying your suggestions from the other mail. Best Regards, Michał Mirosław -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
