On Sun, Apr 25, 2010 at 11:28:17PM +0100, Matt Fleming wrote: > On Wed, 21 Apr 2010 19:43:32 +0800, zhangfei gao <zhangfei.gao@xxxxxxxxx> wrote: > > > > There is compile error when we enable CONFIG_MMC_SDHCI_IO_ACCESSORS, > > and include header file #include "sdhci.h" > > error: macro "writel" passed 3 arguments, but takes just 2 > > > > Interesting... > > It was Anton Vorontsov that added this code; presumably the code has > never been compiled for an ARM board (or any other architecture that > #define's their I/O accessors in asm/io.h). Yep, there wasn't any need for these accessors on other platforms. > It would be better if all architectures declared their I/O accessors as > static inline, but I'm not volunteering to touch all those headers ;-) > Renaming the SDHCI ops is definitely the easiest option. Anton, do you > have a problem with the attached patch to rename the SDHCI accessor > functions? Looks OK. Acked-by: Anton Vorontsov <cbouatmailru@xxxxxxxxx> (for -next, I presume) Thanks! -- Anton Vorontsov email: cbouatmailru@xxxxxxxxx irc://irc.freenode.net/bd2 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
