Suggested-by: Richard Röjfors <richard.rojfors@xxxxxxxxxxxxxx> Signed-off-by: Anton Vorontsov <avorontsov@xxxxxxxxxx> --- On Wed, Mar 17, 2010 at 07:14:03AM +0100, Richard Röjfors wrote: > On 3/16/10 7:34 PM, Anton Vorontsov wrote: > > This includes platform ops, quirks and (de)initialization callbacks. > > Good idea, just a doc comment below. [....] > > +struct sdhci_pltfm_data { > > + struct sdhci_ops *ops; > > + unsigned int quirks; > > + int (*init)(struct sdhci_host *host); > > + void (*exit)(struct sdhci_host *host); > > +}; > > I would like to see this struct kernel-doc:ed. Done, thanks! Andrew, Please fold this patch into sdhci-pltfm-implement-platform-data-passing.patch Thanks, include/linux/sdhci-pltfm.h | 8 ++++++++ 1 files changed, 8 insertions(+), 0 deletions(-) diff --git a/include/linux/sdhci-pltfm.h b/include/linux/sdhci-pltfm.h index 0aaa334..0239bd7 100644 --- a/include/linux/sdhci-pltfm.h +++ b/include/linux/sdhci-pltfm.h @@ -17,6 +17,14 @@ struct sdhci_ops; struct sdhci_host; +/** + * struct sdhci_pltfm_data - SDHCI platform-specific information & hooks + * @ops: optional pointer to the platform-provided SDHCI ops + * @quirks: optional SDHCI quirks + * @init: optional hook that is called during device probe, before the + * driver tries to access any SDHCI registers + * @exit: optional hook that is called during device removal + */ struct sdhci_pltfm_data { struct sdhci_ops *ops; unsigned int quirks; -- 1.7.0.5 -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html