Thiago A. Corrêa <thiago.correa@xxxxxxxxx> wrote: > >> Causes at91_set_gpio_input() to be called for pin -1. Which shouldn't be valid. > >> AT91 platforms use 0 to indicate an un-connected GPIO pin, so the > >> assignment of "wp_pin" should probably just be removed. > > > > The mci driver expects non-existent pins to have a negative value, as > > do all other drivers which use gpio_is_valid(). > > > > Then I think it would be best to use GPIO_PIN_NONE. Makes it clear > what is expected and avoids confusion on what should be the proper > value. Unfortunately, GPIO_PIN_NONE only exists on AVR32. > I hope I'm not saying non-sense, but even if I am, I guess you can see > that I'm advocating against the magic numbers :) IIRC, the correct way to specify a non-existent pin is to use -ENODEV. Haavard -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
