[CC Paul Mundt] On Thu, Oct 1, 2009 at 7:19 PM, Ian Molton <ian@xxxxxxxxxxxxxx> wrote: > 2009/10/1 Magnus Damm <magnus.damm@xxxxxxxxx>: >> Maybe the best option is to hack up a mfd driver for just the >> superh-mobile specific sdhi part. > > I dont see why not - the MFD layer is quite lightweight and you only > need to provide enable and disable hooks. Right, the MFD driver approach is probably the best one. > Your current implementation is broken in that if as you say the clock > rate can vary prior to loading the MMC driver then you will end up > with f_max being set to whatever random clock was set when the driver > probes. No, it's not broken. When the clock is enabled the frequency stays fixed. How would things work at all if that wasn't the case? The clock rate comes from whatever bus frequency that is used for the bus that the SDHI block is hooked up to. So it's far from random. >> At some point I'd like to add runtime pm support to the tmio-mmc >> driver as well. With such a change it should be possible to power down >> the hardware block while the system is idle and re-setup everything >> when next access happens. > > it does stop the clock already when its not in use. (just not the input clock). Yes, the external clock. That's good. I'm talking about the clock driving the SDHI block. The clock stopping is not so exciting though, the real power savings come when we can disable the power to the hardware block as well dynamically. >> Any chance we can get at least the ian-0001 patch and the kconfig bit >> merged in 2.6.32-rc? I realize it's a bit late in the merge cycle >> though. > > I have a complete set of patches here, I'd like to send them in > together, so just waiting on ASIC3 stuff to settle now. I only need the first patch to get SuperH Mobile SDHI up and running. Andrew, Paul, please let me know if you need anything else from me. Cheers, / magnus -- To unsubscribe from this list: send the line "unsubscribe linux-mmc" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
