On Tue, 8 Dec 2015, Thomas Gleixner wrote: > On Tue, 8 Dec 2015, Dave Hansen wrote: > > > Here's how it looks with the suggested modifications. > > > > Whatever compiler wonkiness I was seeing is gone now, so I've used the > > most straightforward version of the shifts. > > > + * gcc generates better code if we do this rather than: > > + * pkey = (flags & mask) >> shift > > + */ > > + pkey = (vma->vm_flags & vma_pkey_mask) >> VM_PKEY_SHIFT; > > ROTFL! Other than that silly comment, it's way better than before. Thanks, tglx -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>