On Mon, 9 Nov 2015 17:21:25 +0100 Michal Hocko <mhocko@xxxxxxxxxx> wrote: > > This patchset introduces two new functions: > > dump_stack_lvl(char *log_lvl) > > show_stack_lvl(struct task_struct *task, unsigned long *sp, char *log_lvl) > > > > and both can be reimplemented by each architecture but only the second is > > expected. The idea is to initially implement show_stack_lvl() in all > > architectures then simply have show_stack() to require log_lvl as parameter. > > While that happens, dump_stack() uses can be changed to dump_stack_lvl() and > > once everything is in place, dump_stack() will require the log_level as well. > > This looks good to me FWIW. Seems reasonable to me as well and yes, there will be extra fill-in work to do. The "lvl" thing stands out - kernel code doesn't do this arbitrary vowelicide to make identifiers shorter. s/lvl/level/g? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>