On Mon, 2015-10-26 at 16:46 +0000, Luck, Tony wrote: > > + ((param2 & PAGE_MASK) != PAGE_MASK)) > > return -EINVAL; > > > > The 3rd condition check makes sure that the param2 mask is the page size or less. So, > > I think we are OK on this. > > Oops. The original was even on the screen as part of the diff (which I signed off on > just two years ago). > > I'd be happier if you made it the 1st condition though, so we skip calling > region_intersects_*() with a nonsense "size" argument. Agreed. I will send an updated patch 3/3 later today, "[PATCH v2 UPDATE-2 3/3]". Thanks, -Toshi -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>