RE: [PATCH v2 UPDATE 3/3] ACPI/APEI/EINJ: Allow memory error injection to NVDIMM

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> +           ((param2 & PAGE_MASK) != PAGE_MASK))
>                return -EINVAL;
>
> The 3rd condition check makes sure that the param2 mask is the page size or less.  So, I
> think we are OK on this.

Oops. The original was even on the screen as part of the diff (which I signed off on just two years ago).

I'd be happier if you made it the 1st condition though, so we skip calling region_intersects_*() with
a nonsense "size" argument.

-Tony

��.n������g����a����&ޖ)���)��h���&������梷�����Ǟ�m������)������^�����������v���O��zf������




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]