On Fri, 18 Sep 2015 12:28:27 +0300 Cyrill Gorcunov <gorcunov@xxxxxxxxx> wrote: > On Fri, Sep 18, 2015 at 11:10:38AM +0200, Martin Schwidefsky wrote: > > > > > > You know, these are only two lines where we use _PAGE_SOFT_DIRTY > > > directly, so I don't see much point in adding 22 lines of code > > > for that. Maybe we can leave it as is? > > > > Only x86 has pte_clear_flags. And the two lines require that there is exactly > > one bit in the PTE for soft-dirty. An alternative encoding will not be allowed. > > And the current set of primitives is asymmetric, there are functions to query > > and set the bit pte_soft_dirty and pte_mksoft_dirty but no function to clear > > the bit. > > OK, Martin, gimme some time please, I don't have code at my hands, so once > I'm back, I'll take a precise look, ok? Sure, thanks. -- blue skies, Martin. "Reality continues to ruin my life." - Calvin. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>