On Sat, 15 Aug 2015 13:48:50 +0600 Alexander Kuleshov <kuleshovmail@xxxxxxxxx> wrote: > On 08-15-15, Andrew Morton wrote: > > Yes, I agree that if memblock's debugfs_create_file() fails, we want to > > know about it because something needs fixing. But that's true of > > all(?) debugfs_create_file callsites, so it's a bit silly to add > > warnings to them all. Why not put the warning into > > debugfs_create_file() itself? > > Good idea, but there are already some debugfs_create_file calls with checks and > warning, if these checks failed. I don't know how many, but I saw it. > Double warning is not good too. Please ponder the sentence you deleted. "Or add a debugfs_create_file_warn() wrapper". -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>