On Wed, Jul 29, 2015 at 10:41:10AM +0530, PINTU KUMAR wrote: > I was talking about only the following case. > Instead of hard coding the hibernation_mode in shrink_all_memory, > We can set it at runtime. > > - .hibernation_mode = 1, > > + if (system_entering_hibernation()) > + sc.hibernation_mode = 1; > + else > + sc.hibernation_mode = 0; Nobody outside hibernation uses this function (and likely never will). The hardcoding is fine. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>