Sorry, for late reply. > -----Original Message----- > From: Mel Gorman [mailto:mgorman@xxxxxxx] > Sent: Wednesday, July 22, 2015 7:36 PM > To: PINTU KUMAR > Cc: akpm@xxxxxxxxxxxxxxxxxxxx; corbet@xxxxxxx; vbabka@xxxxxxx; > gorcunov@xxxxxxxxxx; mhocko@xxxxxxx; emunson@xxxxxxxxxx; > kirill.shutemov@xxxxxxxxxxxxxxx; standby24x7@xxxxxxxxx; > hannes@xxxxxxxxxxx; vdavydov@xxxxxxxxxxxxx; hughd@xxxxxxxxxx; > minchan@xxxxxxxxxx; tj@xxxxxxxxxx; rientjes@xxxxxxxxxx; > xypron.glpk@xxxxxx; dzickus@xxxxxxxxxx; prarit@xxxxxxxxxx; > ebiederm@xxxxxxxxxxxx; rostedt@xxxxxxxxxxx; uobergfe@xxxxxxxxxx; > paulmck@xxxxxxxxxxxxxxxxxx; iamjoonsoo.kim@xxxxxxx; ddstreet@xxxxxxxx; > sasha.levin@xxxxxxxxxx; koct9i@xxxxxxxxx; cj@xxxxxxxxx; > opensource.ganesh@xxxxxxxxx; vinmenon@xxxxxxxxxxxxxx; linux- > doc@xxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; linux-mm@xxxxxxxxx; linux- > pm@xxxxxxxxxxxxxxx; qiuxishi@xxxxxxxxxx; Valdis.Kletnieks@xxxxxx; > cpgs@xxxxxxxxxxx; pintu_agarwal@xxxxxxxxx; vishnu.ps@xxxxxxxxxxx; > rohit.kr@xxxxxxxxxxx; iqbal.ams@xxxxxxxxxxx; pintu.ping@xxxxxxxxx; > pintu.k@xxxxxxxxxxx > Subject: Re: [PATCH v3 1/1] kernel/sysctl.c: Add /proc/sys/vm/shrink_memory > feature > > On Wed, Jul 22, 2015 at 06:33:26PM +0530, PINTU KUMAR wrote: > > Dear Mel, thank you very much for your comments and suggestions. > > I will drop this one and look on further improving direct_reclaim and > > compaction. > > Just few more comments below before I close. > > > > Also, during this patch, I feel that the hibernation_mode part in > > shrink_all_memory can be corrected. > > So, can I separately submit the below patch? > > That is instead of hard-coding the hibernation_mode, we can get > > hibernation status using: > > system_entering_hibernation() > > > > Please let me know your suggestion about this changes. > > > > -#ifdef CONFIG_HIBERNATION > > +#if defined CONFIG_HIBERNATION || CONFIG_SHRINK_MEMORY > I was talking about only the following case. Instead of hard coding the hibernation_mode in shrink_all_memory, We can set it at runtime. - .hibernation_mode = 1, + if (system_entering_hibernation()) + sc.hibernation_mode = 1; + else + sc.hibernation_mode = 0; The PM owners should confirm if this is ok. Once confirmed, I will submit the full patch set. +> This appears to be a patch on top of "Add /proc/sys/vm/shrink_memory feature" > so I do not see what would be separately submitted that would make sense. > And we don't need to have /proc/sys/vm/shrink_memory patch for this. However, if required, we can also expose shrink_all_memory() outside the hibernation using the CONFIG_SHRINK_MEMORY. Otherwise, we can neglect other changes. > -- > Mel Gorman > SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>