This changes us returning the value of one to -ENOMEM when the call for allocating memory with the function kzalloc_node fails in order to better comply with kernel coding pratices of returning this particular error code when memory allocations that are unrecoverable occur. Signed-off-by: Nicholas Krause <xerofoify@xxxxxxxxx> --- mm/memcontrol.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/mm/memcontrol.c b/mm/memcontrol.c index acb93c5..4e80811 100644 --- a/mm/memcontrol.c +++ b/mm/memcontrol.c @@ -4442,7 +4442,7 @@ static int alloc_mem_cgroup_per_zone_info(struct mem_cgroup *memcg, int node) tmp = -1; pn = kzalloc_node(sizeof(*pn), GFP_KERNEL, tmp); if (!pn) - return 1; + return -ENOMEM; for (zone = 0; zone < MAX_NR_ZONES; zone++) { mz = &pn->zoneinfo[zone]; -- 2.1.4 -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>