On Mon 20-04-15 13:56:26, Tejun Heo wrote: > On Mon, Apr 20, 2015 at 05:02:31PM +0200, Jan Kara wrote: > > Maybe bdi_wb_destroy() would be somewhat more descriptive than > > bdi_wb_exit()? Otherwise the patch looks good to me. You can add: > > Reviewed-by: Jan Kara <jack@xxxxxxx> > > Hmmm... maybe, I don't know. I feel weird matching up destroy with > init instead of create. Why is exit weird? I can easily understand what "initializing writeback structure" means but "exiting writeback structure" doesn't really make sense to me. OTOH "destroying writeback structure" does make sense to me. That's the only reason. Honza -- Jan Kara <jack@xxxxxxx> SUSE Labs, CR -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>