On 01/08/2015 09:21 AM, Joonsoo Kim wrote:
>
> Okay. How about adding one more like below?
>
> #define COMPACT_NO_SUITABLE_PAGE
> #define COMPACT_NOT_SUITABLE_ZONE
Yeah that would be less confusing.
> It will distiguish return value properly.
>
>> > return COMPACT_CONTINUE;
>> > }
>> >
>> > +unsigned long compaction_suitable(struct zone *zone, int order,
>> > + int alloc_flags, int classzone_idx)
>> > +{
>> > + unsigned long ret;
>> > +
>> > + ret = __compaction_suitable(zone, order, alloc_flags, classzone_idx);
>> > + trace_mm_compaction_suitable(zone, order, alloc_flags,
>> > + classzone_idx, ret);
>> > + if (ret == COMPACT_NOT_SUITABLE)
>> > + ret = COMPACT_SKIPPED;
>>
>> I don't like this wrapping just for tracepints, but I don't know of a better way :/
>
> Yes, I don't like it, too. :/
>
> Thanks.
>
> --
> To unsubscribe, send a message with 'unsubscribe linux-mm' in
> the body to majordomo@xxxxxxxxx. For more info on Linux MM,
> see: http://www.linux-mm.org/ .
> Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>
>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>