On Tue, Jan 06, 2015 at 12:27:43PM +0100, Vlastimil Babka wrote: > On 12/03/2014 08:52 AM, Joonsoo Kim wrote: > > compaction deferring logic is heavy hammer that block the way to > > the compaction. It doesn't consider overall system state, so it > > could prevent user from doing compaction falsely. In other words, > > even if system has enough range of memory to compact, compaction would be > > skipped due to compaction deferring logic. This patch add new tracepoint > > to understand work of deferring logic. This will also help to check > > compaction success and fail. > > > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> > > You only call the tracepoints from try_to_compact_pages(), but the corresponding > functions are also called from elsewhere, e.g. kswapd. Shouldn't all be > included? Otherwise one might consider the trace as showing a bug, where the > defer state suddenly changed without being captured in the trace. Yes, I should include all the others. I also have experience of this confusion. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>