On Fri, Dec 19, 2014 at 07:18:28PM -0800, Omar Sandoval wrote: > + ret = swap_file->f_op->read_iter(&kiocb, &to); > + if (ret == PAGE_SIZE) { > + SetPageUptodate(page); > count_vm_event(PSWPIN); > + ret = 0; > + } else { > + ClearPageUptodate(page); > + SetPageError(page); > + } > + unlock_page(page); Umm... What's to guarantee that ->read_iter() won't try lock_page() on what turns out to be equal to page? -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx"> email@xxxxxxxxx </a>