On Wed, Dec 03, 2014 at 10:50:35PM +0530, Aneesh Kumar K.V wrote: > Mel Gorman <mgorman@xxxxxxx> writes: > > > On Wed, Dec 03, 2014 at 08:53:37PM +0530, Aneesh Kumar K.V wrote: > >> Benjamin Herrenschmidt <benh@xxxxxxxxxxxxxxxxxxx> writes: > >> > >> > On Tue, 2014-12-02 at 12:57 +0530, Aneesh Kumar K.V wrote: > >> >> Now, hash_preload can possibly insert an hpte in hash page table even if > >> >> the access is not allowed by the pte permissions. But i guess even that > >> >> is ok. because we will fault again, end-up calling hash_page_mm where we > >> >> handle that part correctly. > >> > > >> > I think we need a test case... > >> > > >> > >> I ran the subpageprot test that Paul had written. I modified it to ran > >> with selftest. > >> > > > > It's implied but can I assume it passed? > > Yes. > > -bash-4.2# ./subpage_prot > test: subpage_prot > tags: git_version:v3.17-rc3-13511-g0cd3756 > allocated malloc block of 0x4000000 bytes at 0x0x3fffb0d10000 > testing malloc block... > OK > success: subpage_prot > -bash-4.2# > Thanks for adding that and double checking. I won't pick up the patch as part of this series because it's not directly related but I would strongly suggest sending the patch separately. -- Mel Gorman SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>