On Mon, Oct 27, 2014 at 11:33:20AM +0100, Vlastimil Babka wrote: > On 10/23/2014 10:10 AM, Joonsoo Kim wrote: > > Changes from v3: > > Add one more check in free_one_page() that checks whether migratetype is > > MIGRATE_ISOLATE or not. Without this, abovementioned case 1 could happens. > > Good catch. > > > Cc: <stable@xxxxxxxxxxxxxxx> > > Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@xxxxxxx> > > Acked-by: Vlastimil Babka <vbabka@xxxxxxx> > > (minor suggestion below) > > > --- a/mm/page_alloc.c > > +++ b/mm/page_alloc.c > > @@ -749,9 +749,16 @@ static void free_one_page(struct zone *zone, > > if (nr_scanned) > > __mod_zone_page_state(zone, NR_PAGES_SCANNED, -nr_scanned); > > > > + if (unlikely(has_isolate_pageblock(zone) || > > Would it make any difference if this was read just once and not in each > loop iteration? > > I guess that you'd like to say this to patch 2. I can do it, but, it doesn't any difference in terms of performance, because we access zone's member variable in each loop iteration in __free_one_page(). Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>