On Mon, Oct 27, 2014 at 10:11:31AM +0100, Vlastimil Babka wrote: > On 10/27/2014 07:46 AM, Joonsoo Kim wrote: > > On Tue, Oct 07, 2014 at 05:33:35PM +0200, Vlastimil Babka wrote: > > > > Hello, > > > > compaction_suitable() has one more zone_watermark_ok(). Why is it > > unchanged? > > Hi, > > it's a check whether there are enough free pages to perform compaction, > which means enough migration targets and temporary copies during > migration. These allocations are not affected by the flags of the > process that makes the high-order allocation. Hmm... To check whether enough free page is there or not needs zone index and alloc flag. What we need to ignore is just order information, IMO. If there is not enough free page in that zone, compaction progress doesn't have any meaning. It will fail due to shortage of free page after successful compaction. I guess that __isolate_free_page() is also good candidate to need this information in order to prevent compaction from isolating too many freepage in low memory condition. Thanks. -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>