On Fri 25-07-14 11:26:54, Johannes Weiner wrote: > On Thu, Jul 24, 2014 at 11:02:57AM +0200, Michal Hocko wrote: > > On Thu 24-07-14 10:46:44, Michal Hocko wrote: > > > On Wed 23-07-14 17:02:41, Johannes Weiner wrote: > > [...] > > > We can reduce the lookup only to lruvec==true case, no? > > > > Dohh > > s@can@should@ > > > > newpage shouldn't charged in all other cases and it would be bug. > > Or am I missing something? > > Yeah, but I'd hate to put that assumption onto the @lrucare parameter, > it just coincides. Yes, you are right. Maybe replace_page_cache_page should have it's own memcg variant which does all the trickery and then call mem_cgroup_migrate when necessary... -- Michal Hocko SUSE Labs -- To unsubscribe, send a message with 'unsubscribe linux-mm' in the body to majordomo@xxxxxxxxx. For more info on Linux MM, see: http://www.linux-mm.org/ . Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>