Re: [PATCH v7 03/10] x86, mpx: add macro cpu_has_mpx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 07/22/2014 07:35 PM, Ren, Qiaowei wrote:
> The checking about MPX feature should be as follow:
> 
>         if (pcntxt_mask & XSTATE_EAGER) {
>                 if (eagerfpu == DISABLE) {
>                         pr_err("eagerfpu not present, disabling some xstate features: 0x%llx\n",
>                                         pcntxt_mask & XSTATE_EAGER);
>                         pcntxt_mask &= ~XSTATE_EAGER;
>                 } else {
>                         eagerfpu = ENABLE;
>                 }
>         }
> 
> This patch was merged into kernel the ending of last year (https://git.kernel.org/cgit/linux/kernel/git/torvalds/linux.git/commit/?id=e7d820a5e549b3eb6c3f9467507566565646a669 )

Should we be doing a clear_cpu_cap(X86_FEATURE_MPX) in here?

This isn't major, but I can't _ever_ imagine a user being able to track
down why MPX is not working from this message.  Should we spruce it up
somehow?

--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@xxxxxxxxx.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@xxxxxxxxx";> email@xxxxxxxxx </a>




[Index of Archives]     [Linux ARM Kernel]     [Linux ARM]     [Linux Omap]     [Fedora ARM]     [IETF Annouce]     [Bugtraq]     [Linux]     [Linux OMAP]     [Linux MIPS]     [ECOS]     [Asterisk Internet PBX]     [Linux API]